Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add subject template group api #273

Merged
merged 11 commits into from
Nov 30, 2023

Conversation

zhu327
Copy link
Member

@zhu327 zhu327 commented Oct 24, 2023

变更点(Changes)

  • xxxx

相关issues (Which issues this PR fixes)

  • Fixes #

备注(Special notes)

@zhu327 zhu327 marked this pull request as ready for review October 25, 2023 08:08
@zhu327 zhu327 requested a review from wklken October 25, 2023 08:08
go.mod Outdated Show resolved Hide resolved
pkg/database/dao/subject_template_group.go Outdated Show resolved Hide resolved
GroupPK int64
ExpiredAt int64

NeedUpdate bool // 是否需要更新subject system group, 默认为false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

名字上更明确些, NeedUpdateSubjectSystemGroup

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

实际上除了subject system group需要变更外, 还需要变更除了当前数据的其它的subject relation与subject template group, 所以不是很好定义这个名字

pkg/service/group.go Show resolved Hide resolved
pkg/service/group.go Show resolved Hide resolved
pkg/service/group_alter_event.go Show resolved Hide resolved
pkg/service/group.go Show resolved Hide resolved
@zhu327 zhu327 merged commit a932930 into TencentBlueKing:develop Nov 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants